drm/amd/display: fix 64-bit division issue on 32-bit OS
authorLang Yu <Lang.Yu@amd.com>
Fri, 22 Jan 2021 08:42:01 +0000 (16:42 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 25 Jan 2021 22:45:53 +0000 (17:45 -0500)
Replace "/" with div_u64 for 32-bit OS. On 32-bit OS,
the use of "/" for 64-bit division will cause build error,
i.e. "__udivdi3/__divdi3 undefined!".

Fixes: ea7154d8d9fb26 ("drm/amd/display: Update dcn30_apply_idle_power_optimizations() code")
Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Acked-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c

index dff83c6..9620fb8 100644 (file)
@@ -772,8 +772,8 @@ bool dcn30_apply_idle_power_optimizations(struct dc *dc, bool enable)
                                                        cursor_cache_enable ? &cursor_attr : NULL)) {
                                unsigned int v_total = stream->adjust.v_total_max ?
                                                stream->adjust.v_total_max : stream->timing.v_total;
-                               unsigned int refresh_hz = (unsigned long long) stream->timing.pix_clk_100hz *
-                                               100LL / (v_total * stream->timing.h_total);
+                               unsigned int refresh_hz = div_u64((unsigned long long) stream->timing.pix_clk_100hz *
+                                               100LL, (v_total * stream->timing.h_total));
 
                                /*
                                 * one frame time in microsec:
@@ -800,8 +800,8 @@ bool dcn30_apply_idle_power_optimizations(struct dc *dc, bool enable)
                                unsigned int denom = refresh_hz * 6528;
                                unsigned int stutter_period = dc->current_state->perf_params.stutter_period_us;
 
-                               tmr_delay = (((1000000LL + 2 * stutter_period * refresh_hz) *
-                                               (100LL + dc->debug.mall_additional_timer_percent) + denom - 1) /
+                               tmr_delay = div_u64(((1000000LL + 2 * stutter_period * refresh_hz) *
+                                               (100LL + dc->debug.mall_additional_timer_percent) + denom - 1),
                                                denom) - 64LL;
 
                                /* scale should be increased until it fits into 6 bits */
@@ -815,8 +815,8 @@ bool dcn30_apply_idle_power_optimizations(struct dc *dc, bool enable)
                                        }
 
                                        denom *= 2;
-                                       tmr_delay = (((1000000LL + 2 * stutter_period * refresh_hz) *
-                                                       (100LL + dc->debug.mall_additional_timer_percent) + denom - 1) /
+                                       tmr_delay = div_u64(((1000000LL + 2 * stutter_period * refresh_hz) *
+                                                       (100LL + dc->debug.mall_additional_timer_percent) + denom - 1),
                                                        denom) - 64LL;
                                }