crypto: testmgr - do comparison tests before inauthentic input tests
authorEric Biggers <ebiggers@google.com>
Wed, 4 Mar 2020 22:44:04 +0000 (14:44 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 12 Mar 2020 12:00:13 +0000 (23:00 +1100)
Do test_aead_vs_generic_impl() before test_aead_inauthentic_inputs() so
that any differences with the generic driver are detected before getting
to the inauthentic input tests, which intentionally use only the driver
being tested (so that they run even if a generic driver is unavailable).

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/testmgr.c

index 0a10dbd..428a5f8 100644 (file)
@@ -2512,11 +2512,11 @@ static int test_aead_extra(const char *driver,
                goto out;
        }
 
-       err = test_aead_inauthentic_inputs(ctx);
+       err = test_aead_vs_generic_impl(ctx);
        if (err)
                goto out;
 
-       err = test_aead_vs_generic_impl(ctx);
+       err = test_aead_inauthentic_inputs(ctx);
 out:
        kfree(ctx->vec.key);
        kfree(ctx->vec.iv);