net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Mon, 13 Nov 2023 16:50:30 +0000 (08:50 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 15 Nov 2023 03:45:35 +0000 (19:45 -0800)
No functional change, uses the existing ETH_P_REALTEK constant already
defined in if_ether.h.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20231113165030.2440083-1-florian.fainelli@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/tag_rtl4_a.c

index 4da5bad..a019226 100644 (file)
@@ -23,7 +23,6 @@
 #define RTL4_A_NAME            "rtl4a"
 
 #define RTL4_A_HDR_LEN         4
-#define RTL4_A_ETHERTYPE       0x8899
 #define RTL4_A_PROTOCOL_SHIFT  12
 /*
  * 0x1 = Realtek Remote Control protocol (RRCP)
@@ -54,7 +53,7 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb,
 
        /* Set Ethertype */
        p = (__be16 *)tag;
-       *p = htons(RTL4_A_ETHERTYPE);
+       *p = htons(ETH_P_REALTEK);
 
        out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT);
        /* The lower bits indicate the port number */
@@ -82,7 +81,7 @@ static struct sk_buff *rtl4a_tag_rcv(struct sk_buff *skb,
        tag = dsa_etype_header_pos_rx(skb);
        p = (__be16 *)tag;
        etype = ntohs(*p);
-       if (etype != RTL4_A_ETHERTYPE) {
+       if (etype != ETH_P_REALTEK) {
                /* Not custom, just pass through */
                netdev_dbg(dev, "non-realtek ethertype 0x%04x\n", etype);
                return skb;