io_uring: remove uring_cmd cookie
authorKeith Busch <kbusch@kernel.org>
Thu, 30 Nov 2023 21:53:09 +0000 (13:53 -0800)
committerJens Axboe <axboe@kernel.dk>
Sat, 2 Dec 2023 01:29:18 +0000 (18:29 -0700)
No more users of this field.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20231130215309.2923568-5-kbusch@meta.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/io_uring.h
io_uring/uring_cmd.c

index fe23bf8..9e6ce6d 100644 (file)
@@ -32,12 +32,8 @@ enum io_uring_cmd_flags {
 struct io_uring_cmd {
        struct file     *file;
        const struct io_uring_sqe *sqe;
-       union {
-               /* callback to defer completions to task context */
-               void (*task_work_cb)(struct io_uring_cmd *cmd, unsigned);
-               /* used for polled completion */
-               void *cookie;
-       };
+       /* callback to defer completions to task context */
+       void (*task_work_cb)(struct io_uring_cmd *cmd, unsigned);
        u32             cmd_op;
        u32             flags;
        u8              pdu[32]; /* available inline for free use */
index acbc292..b39ec25 100644 (file)
@@ -182,7 +182,6 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags)
                        return -EOPNOTSUPP;
                issue_flags |= IO_URING_F_IOPOLL;
                req->iopoll_completed = 0;
-               WRITE_ONCE(ioucmd->cookie, NULL);
        }
 
        ret = file->f_op->uring_cmd(ioucmd, issue_flags);