projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
386fe06
)
dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Sat, 15 Jan 2022 07:35:20 +0000
(08:35 +0100)
committer
Vinod Koul
<vkoul@kernel.org>
Fri, 11 Mar 2022 09:53:23 +0000
(15:23 +0530)
As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
Simplify code and remove some dead code accordingly.
[1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link:
https://lore.kernel.org/r/4deb32b0c7838da66608022c584326eb01d0da03.1642232106.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/hidma.c
patch
|
blob
|
history
diff --git
a/drivers/dma/qcom/hidma.c
b/drivers/dma/qcom/hidma.c
index
65d054b
..
51587cf
100644
(file)
--- a/
drivers/dma/qcom/hidma.c
+++ b/
drivers/dma/qcom/hidma.c
@@
-838,9
+838,7
@@
static int hidma_probe(struct platform_device *pdev)
rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
if (rc) {
dev_warn(&pdev->dev, "unable to set coherent mask to 64");
- rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
- if (rc)
- goto dmafree;
+ goto dmafree;
}
dmadev->lldev = hidma_ll_init(dmadev->ddev.dev,