platform: mellanox: nvsw-sn2200: Fix .items in nvsw_sn2201_busbar_hotplug
authorNathan Chancellor <nathan@kernel.org>
Fri, 9 May 2025 10:58:01 +0000 (11:58 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Sun, 11 May 2025 20:39:16 +0000 (23:39 +0300)
Clang warns (or errors with CONFIG_WERROR=y):

  drivers/platform/mellanox/nvsw-sn2201.c:531:32: error: variable 'nvsw_sn2201_busbar_items' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
    531 | static struct mlxreg_core_item nvsw_sn2201_busbar_items[] = {
        |                                ^~~~~~~~~~~~~~~~~~~~~~~~

nvsw_sn2201_busbar_items is only used in ARRAY_SIZE(), which uses
sizeof(), so this variable is only used at compile time. It appears that
this may be a copy and paste issue, so use nvsw_sn2201_busbar_items as
the .items member in nvsw_sn2201_busbar_hotplug, clearing up the
warning.

Fixes: 56b0bb7f9069 ("platform: mellanox: nvsw-sn2200: Add support for new system flavour")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20250509-nvsw-sn2200-fix-items-busbar-hotplug-v1-1-8844fff38dc8@kernel.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/mellanox/nvsw-sn2201.c

index 8c31189..db31c8b 100644 (file)
@@ -551,7 +551,7 @@ static struct mlxreg_core_item nvsw_sn2201_busbar_items[] = {
 
 static
 struct mlxreg_core_hotplug_platform_data nvsw_sn2201_busbar_hotplug = {
-       .items = nvsw_sn2201_items,
+       .items = nvsw_sn2201_busbar_items,
        .count = ARRAY_SIZE(nvsw_sn2201_busbar_items),
        .cell = NVSW_SN2201_SYS_INT_STATUS_OFFSET,
        .mask = NVSW_SN2201_CPLD_AGGR_BUSBAR_MASK_DEF,