net: ethernet: renesas: rswitch: Fix error path in renesas_eth_sw_probe()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 26 Dec 2022 07:13:27 +0000 (16:13 +0900)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Dec 2022 10:09:49 +0000 (10:09 +0000)
If rswitch_init() returns non-zero and this driver is re-probed,
the following error happens:

    renesas_eth_sw e6880000.ethernet: Unbalanced pm_runtime_enable!

So, fix error path in renesas_eth_sw_probe().

Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/rswitch.c

index e42ceaa..473d86b 100644 (file)
@@ -1786,6 +1786,11 @@ static int renesas_eth_sw_probe(struct platform_device *pdev)
        pm_runtime_get_sync(&pdev->dev);
 
        ret = rswitch_init(priv);
+       if (ret < 0) {
+               pm_runtime_put(&pdev->dev);
+               pm_runtime_disable(&pdev->dev);
+               return ret;
+       }
 
        device_set_wakeup_capable(&pdev->dev, 1);