can: mcp25xxfd: mcp25xxfd_ring_free(): fix memory leak during cleanup
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 23 Sep 2020 11:27:52 +0000 (14:27 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 30 Sep 2020 08:34:30 +0000 (10:34 +0200)
This loop doesn't free the first element of the array.  The "i > 0" has
to be changed to "i >= 0".

Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200923112752.GA1473821@mwanda
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c

index c094bb7..b91180b 100644 (file)
@@ -377,7 +377,7 @@ static void mcp25xxfd_ring_free(struct mcp25xxfd_priv *priv)
 {
        int i;
 
-       for (i = ARRAY_SIZE(priv->rx) - 1; i > 0; i--) {
+       for (i = ARRAY_SIZE(priv->rx) - 1; i >= 0; i--) {
                kfree(priv->rx[i]);
                priv->rx[i] = NULL;
        }