seccomp: Stub for !HAVE_ARCH_SECCOMP_FILTER
authorLinus Walleij <linus.walleij@linaro.org>
Tue, 22 Oct 2024 13:41:34 +0000 (15:41 +0200)
committerKees Cook <kees@kernel.org>
Tue, 22 Oct 2024 19:35:14 +0000 (12:35 -0700)
If we have CONFIG_SECCOMP but not CONFIG_HAVE_ARCH_SECCOMP_FILTER
we get a compilation error:

../kernel/entry/common.c: In function 'syscall_trace_enter':
../kernel/entry/common.c:55:23: error: implicit declaration of function '__secure_computing' [-Werror=implicit-function-declaration]
   55 |                 ret = __secure_computing(NULL);
      |                       ^~~~~~~~~~~~~~~~~~

This is because generic entry calls __secure_computing()
unconditionally.

Provide the needed stub similar to how current ARM does
this by calling secure_computing_strict() in the absence
of secure_computing(). This is similar to what is done for
ARM in arch/arm/kernel/ptrace.c.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20241022-seccomp-compile-error-v2-1-c9f08a4f8ebb@linaro.org
Signed-off-by: Kees Cook <kees@kernel.org>
include/linux/seccomp.h

index 709ad84..3419805 100644 (file)
@@ -32,6 +32,11 @@ static inline int secure_computing(void)
 }
 #else
 extern void secure_computing_strict(int this_syscall);
+static inline int __secure_computing(const struct seccomp_data *sd)
+{
+       secure_computing_strict(sd->nr);
+       return 0;
+}
 #endif
 
 extern long prctl_get_seccomp(void);