usb: dwc2: gadget: move gadget resume after the core is in L0 state
authorFabrice Gasnier <fabrice.gasnier@st.com>
Thu, 23 Apr 2020 11:55:53 +0000 (13:55 +0200)
committerFelipe Balbi <balbi@kernel.org>
Mon, 25 May 2020 08:09:39 +0000 (11:09 +0300)
When the remote wakeup interrupt is triggered, lx_state is resumed from L2
to L0 state. But when the gadget resume is called, lx_state is still L2.
This prevents the resume callback to queue any request. Any attempt
to queue a request from resume callback will result in:
- "submit request only in active state" debug message to be issued
- dwc2_hsotg_ep_queue() returns -EAGAIN

Call the gadget resume routine after the core is in L0 state.

Fixes: f81f46e1f530 ("usb: dwc2: implement hibernation during bus suspend/resume")

Acked-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/dwc2/core_intr.c

index 876ff31..55f1d14 100644 (file)
@@ -416,10 +416,13 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
                        if (ret && (ret != -ENOTSUPP))
                                dev_err(hsotg->dev, "exit power_down failed\n");
 
+                       /* Change to L0 state */
+                       hsotg->lx_state = DWC2_L0;
                        call_gadget(hsotg, resume);
+               } else {
+                       /* Change to L0 state */
+                       hsotg->lx_state = DWC2_L0;
                }
-               /* Change to L0 state */
-               hsotg->lx_state = DWC2_L0;
        } else {
                if (hsotg->params.power_down)
                        return;