memstick: core: Assign error code of mspro_block_resume()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 5 Mar 2021 02:14:45 +0000 (18:14 -0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 30 Mar 2021 09:42:02 +0000 (11:42 +0200)
When mspro_block_init_card() fails, no error return code of
mspro_block_resume() is assigned/propagated. Let's fix this.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20210305021445.3435-1-baijiaju1990@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/memstick/core/mspro_block.c

index afb892e..cf7fe0d 100644 (file)
@@ -1382,7 +1382,8 @@ static int mspro_block_resume(struct memstick_dev *card)
 
        new_msb->card = card;
        memstick_set_drvdata(card, new_msb);
-       if (mspro_block_init_card(card))
+       rc = mspro_block_init_card(card);
+       if (rc)
                goto out_free;
 
        for (cnt = 0; new_msb->attr_group.attrs[cnt]