crypto: spacc - Fix NULL vs IS_ERR() check in spacc_aead_fallback()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 15 Aug 2024 11:20:12 +0000 (14:20 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 24 Aug 2024 13:38:54 +0000 (21:38 +0800)
The crypto_alloc_aead() function doesn't return NULL pointers, it returns
error pointers.  Fix the error checking.

Fixes: 06af76b46c78 ("crypto: spacc - Add SPAcc aead support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/dwc-spacc/spacc_aead.c

index abf5971..7f6c488 100755 (executable)
@@ -769,9 +769,9 @@ static int spacc_aead_fallback(struct aead_request *req,
        ctx->fb.aead = crypto_alloc_aead(aead_name, 0,
                                         CRYPTO_ALG_NEED_FALLBACK |
                                         CRYPTO_ALG_ASYNC);
-       if (!ctx->fb.aead) {
+       if (IS_ERR(ctx->fb.aead)) {
                pr_err("Spacc aead fallback tfm is NULL!\n");
-               return -EINVAL;
+               return PTR_ERR(ctx->fb.aead);
        }
 
        subreq = aead_request_alloc(ctx->fb.aead, GFP_KERNEL);