pinctrl: at91-pio4: account for const type of of_device_id.data
authorJulia Lawall <Julia.Lawall@lip6.fr>
Tue, 2 Jan 2018 13:27:58 +0000 (14:27 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 8 Jan 2018 07:15:47 +0000 (08:15 +0100)
This driver creates a const structure that it stores in the data field
of an of_device_id array.

Adding const to the declaration of the location that receives the
const value from the data field ensures that the compiler will
continue to check that the value is not modified.  Furthermore, the
const-discarding cast on the extraction from the data field is no
longer needed.

Done using Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-at91-pio4.c

index b1ca838..4b57a13 100644 (file)
@@ -910,7 +910,7 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
        int i, ret;
        struct resource *res;
        struct atmel_pioctrl *atmel_pioctrl;
-       struct atmel_pioctrl_data *atmel_pioctrl_data;
+       const struct atmel_pioctrl_data *atmel_pioctrl_data;
 
        atmel_pioctrl = devm_kzalloc(dev, sizeof(*atmel_pioctrl), GFP_KERNEL);
        if (!atmel_pioctrl)
@@ -924,7 +924,7 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
                dev_err(dev, "unknown compatible string\n");
                return -ENODEV;
        }
-       atmel_pioctrl_data = (struct atmel_pioctrl_data *)match->data;
+       atmel_pioctrl_data = match->data;
        atmel_pioctrl->nbanks = atmel_pioctrl_data->nbanks;
        atmel_pioctrl->npins = atmel_pioctrl->nbanks * ATMEL_PIO_NPINS_PER_BANK;