nvme-tcp: block BH in sk state_change sk callback
authorSagi Grimberg <sagi@grimberg.me>
Sun, 21 Mar 2021 07:08:48 +0000 (00:08 -0700)
committerChristoph Hellwig <hch@lst.de>
Fri, 2 Apr 2021 16:48:28 +0000 (18:48 +0200)
The TCP stack can run from process context for a long time
so we should disable BH here.

Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/tcp.c

index 7de9bee..b9e8ea3 100644 (file)
@@ -870,7 +870,7 @@ static void nvme_tcp_state_change(struct sock *sk)
 {
        struct nvme_tcp_queue *queue;
 
-       read_lock(&sk->sk_callback_lock);
+       read_lock_bh(&sk->sk_callback_lock);
        queue = sk->sk_user_data;
        if (!queue)
                goto done;
@@ -891,7 +891,7 @@ static void nvme_tcp_state_change(struct sock *sk)
 
        queue->state_change(sk);
 done:
-       read_unlock(&sk->sk_callback_lock);
+       read_unlock_bh(&sk->sk_callback_lock);
 }
 
 static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)