[media] au0828: Delete unnecessary checks before the function call "video_unregister_...
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 3 Feb 2015 18:00:25 +0000 (15:00 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 2 Mar 2015 17:53:46 +0000 (14:53 -0300)
The video_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/au0828/au0828-video.c

index a27cb5f..b49fe91 100644 (file)
@@ -899,12 +899,8 @@ void au0828_analog_unregister(struct au0828_dev *dev)
 {
        dprintk(1, "au0828_analog_unregister called\n");
        mutex_lock(&au0828_sysfs_lock);
-
-       if (dev->vdev)
-               video_unregister_device(dev->vdev);
-       if (dev->vbi_dev)
-               video_unregister_device(dev->vbi_dev);
-
+       video_unregister_device(dev->vdev);
+       video_unregister_device(dev->vbi_dev);
        mutex_unlock(&au0828_sysfs_lock);
 }