xfs: set inode size after creating symlink
authorJeffrey Mitchell <jeffrey.mitchell@starlab.io>
Sat, 23 Jan 2021 00:48:20 +0000 (16:48 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Sat, 23 Jan 2021 00:54:50 +0000 (16:54 -0800)
When XFS creates a new symlink, it writes its size to disk but not to the
VFS inode. This causes i_size_read() to return 0 for that symlink until
it is re-read from disk, for example when the system is rebooted.

I found this inconsistency while protecting directories with eCryptFS.
The command "stat path/to/symlink/in/ecryptfs" will report "Size: 0" if
the symlink was created after the last reboot on an XFS root.

Call i_size_write() in xfs_symlink()

Signed-off-by: Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
fs/xfs/xfs_symlink.c

index 0b8136a..7f96649 100644 (file)
@@ -305,6 +305,7 @@ xfs_symlink(
                }
                ASSERT(pathlen == 0);
        }
+       i_size_write(VFS_I(ip), ip->i_d.di_size);
 
        /*
         * Create the directory entry for the symlink.