ep93xx: clock: Do not return the address of the freed memory
authorGenjian Zhang <zhanggenjian123@gmail.com>
Tue, 17 May 2022 07:39:46 +0000 (15:39 +0800)
committerArnd Bergmann <arnd@arndb.de>
Fri, 27 May 2022 13:55:44 +0000 (15:55 +0200)
Avoid return freed memory addresses,Modified to the actual error
return value of clk_register().

Fixes: 9645ccc7bd7a ("ep93xx: clock: convert in-place to COMMON_CLK")
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm/mach-ep93xx/clock.c

index 4fa6ea5..85a496d 100644 (file)
@@ -345,9 +345,10 @@ static struct clk_hw *clk_hw_register_ddiv(const char *name,
        psc->hw.init = &init;
 
        clk = clk_register(NULL, &psc->hw);
-       if (IS_ERR(clk))
+       if (IS_ERR(clk)) {
                kfree(psc);
-
+               return ERR_CAST(clk);
+       }
        return &psc->hw;
 }
 
@@ -452,9 +453,10 @@ static struct clk_hw *clk_hw_register_div(const char *name,
        psc->hw.init = &init;
 
        clk = clk_register(NULL, &psc->hw);
-       if (IS_ERR(clk))
+       if (IS_ERR(clk)) {
                kfree(psc);
-
+               return ERR_CAST(clk);
+       }
        return &psc->hw;
 }