iio: fix devm_iio_trigger_alloc with parent.cocci
authorGwendal Grignou <gwendal@chromium.org>
Tue, 9 Mar 2021 19:36:14 +0000 (11:36 -0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 25 Mar 2021 19:13:50 +0000 (19:13 +0000)
Use cocci semantic patch:
@@
expression trigger, P;
@@
   trigger = devm_iio_trigger_alloc(P, ...);
   ...
-  trigger->dev.parent = P;

To remove trigger->dev.parent, since it is set by default.

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210309193620.2176163-3-gwendal@chromium.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
30 files changed:
drivers/iio/accel/adxl372.c
drivers/iio/accel/bmc150-accel-core.c
drivers/iio/accel/kxcjk-1013.c
drivers/iio/accel/mma8452.c
drivers/iio/accel/mxc4005.c
drivers/iio/accel/stk8312.c
drivers/iio/accel/stk8ba50.c
drivers/iio/adc/ad7606.c
drivers/iio/adc/ad7766.c
drivers/iio/adc/ad7768-1.c
drivers/iio/adc/max1027.c
drivers/iio/chemical/ccs811.c
drivers/iio/chemical/scd30_core.c
drivers/iio/gyro/adxrs290.c
drivers/iio/gyro/bmg160_core.c
drivers/iio/gyro/fxas21002c_core.c
drivers/iio/health/afe4403.c
drivers/iio/health/afe4404.c
drivers/iio/humidity/hts221_buffer.c
drivers/iio/imu/kmx61.c
drivers/iio/light/rpr0521.c
drivers/iio/light/si1145.c
drivers/iio/light/st_uvis25_core.c
drivers/iio/light/vcnl4000.c
drivers/iio/light/vcnl4035.c
drivers/iio/magnetometer/bmc150_magn.c
drivers/iio/magnetometer/rm3100-core.c
drivers/iio/pressure/zpa2326.c
drivers/iio/proximity/sx9310.c
drivers/iio/proximity/sx9500.c

index 8ba1453..9c9a896 100644 (file)
@@ -1236,8 +1236,6 @@ int adxl372_probe(struct device *dev, struct regmap *regmap,
 
                st->dready_trig->ops = &adxl372_trigger_ops;
                st->peak_datardy_trig->ops = &adxl372_peak_data_trigger_ops;
-               st->dready_trig->dev.parent = dev;
-               st->peak_datardy_trig->dev.parent = dev;
                iio_trigger_set_drvdata(st->dready_trig, indio_dev);
                iio_trigger_set_drvdata(st->peak_datardy_trig, indio_dev);
                ret = devm_iio_trigger_register(dev, st->dready_trig);
index b0dbd12..04d85ce 100644 (file)
@@ -1478,7 +1478,6 @@ static int bmc150_accel_triggers_setup(struct iio_dev *indio_dev,
                        break;
                }
 
-               t->indio_trig->dev.parent = dev;
                t->indio_trig->ops = &bmc150_accel_trigger_ops;
                t->intr = bmc150_accel_triggers[i].intr;
                t->data = data;
index 5c05616..ff724bc 100644 (file)
@@ -1419,7 +1419,6 @@ static int kxcjk1013_probe(struct i2c_client *client,
                        goto err_poweroff;
                }
 
-               data->dready_trig->dev.parent = &client->dev;
                data->dready_trig->ops = &kxcjk1013_trigger_ops;
                iio_trigger_set_drvdata(data->dready_trig, indio_dev);
                indio_dev->trig = data->dready_trig;
@@ -1428,7 +1427,6 @@ static int kxcjk1013_probe(struct i2c_client *client,
                if (ret)
                        goto err_poweroff;
 
-               data->motion_trig->dev.parent = &client->dev;
                data->motion_trig->ops = &kxcjk1013_trigger_ops;
                iio_trigger_set_drvdata(data->motion_trig, indio_dev);
                ret = iio_trigger_register(data->motion_trig);
index 33f0c41..4d307df 100644 (file)
@@ -1465,7 +1465,6 @@ static int mma8452_trigger_setup(struct iio_dev *indio_dev)
        if (!trig)
                return -ENOMEM;
 
-       trig->dev.parent = &data->client->dev;
        trig->ops = &mma8452_trigger_ops;
        iio_trigger_set_drvdata(trig, indio_dev);
 
index 0f8fd68..fb3cbaa 100644 (file)
@@ -450,7 +450,6 @@ static int mxc4005_probe(struct i2c_client *client,
                        return ret;
                }
 
-               data->dready_trig->dev.parent = &client->dev;
                data->dready_trig->ops = &mxc4005_trigger_ops;
                iio_trigger_set_drvdata(data->dready_trig, indio_dev);
                indio_dev->trig = data->dready_trig;
index 1a8a1a0..157d8fa 100644 (file)
@@ -558,7 +558,6 @@ static int stk8312_probe(struct i2c_client *client,
                        goto err_power_off;
                }
 
-               data->dready_trig->dev.parent = &client->dev;
                data->dready_trig->ops = &stk8312_trigger_ops;
                iio_trigger_set_drvdata(data->dready_trig, indio_dev);
                ret = iio_trigger_register(data->dready_trig);
index 7a06904..7cf9cb7 100644 (file)
@@ -454,7 +454,6 @@ static int stk8ba50_probe(struct i2c_client *client,
                        goto err_power_off;
                }
 
-               data->dready_trig->dev.parent = &client->dev;
                data->dready_trig->ops = &stk8ba50_trigger_ops;
                iio_trigger_set_drvdata(data->dready_trig, indio_dev);
                ret = iio_trigger_register(data->dready_trig);
index ee7b108..0af0bb4 100644 (file)
@@ -668,7 +668,6 @@ int ad7606_probe(struct device *dev, int irq, void __iomem *base_address,
                return -ENOMEM;
 
        st->trig->ops = &ad7606_trigger_ops;
-       st->trig->dev.parent = dev;
        iio_trigger_set_drvdata(st->trig, indio_dev);
        ret = devm_iio_trigger_register(dev, st->trig);
        if (ret)
index b6b6765..829a342 100644 (file)
@@ -253,7 +253,6 @@ static int ad7766_probe(struct spi_device *spi)
                        return -ENOMEM;
 
                ad7766->trig->ops = &ad7766_trigger_ops;
-               ad7766->trig->dev.parent = &spi->dev;
                iio_trigger_set_drvdata(ad7766->trig, ad7766);
 
                ret = devm_request_irq(&spi->dev, spi->irq, ad7766_irq,
index 5c0cbee..c945f13 100644 (file)
@@ -631,7 +631,6 @@ static int ad7768_probe(struct spi_device *spi)
                return -ENOMEM;
 
        st->trig->ops = &ad7768_trigger_ops;
-       st->trig->dev.parent = &spi->dev;
        iio_trigger_set_drvdata(st->trig, indio_dev);
        ret = devm_iio_trigger_register(&spi->dev, st->trig);
        if (ret)
index ca1dff3..e3c8ec1 100644 (file)
@@ -473,7 +473,6 @@ static int max1027_probe(struct spi_device *spi)
                }
 
                st->trig->ops = &max1027_trigger_ops;
-               st->trig->dev.parent = &spi->dev;
                iio_trigger_set_drvdata(st->trig, indio_dev);
                ret = devm_iio_trigger_register(&indio_dev->dev,
                                                st->trig);
index 60dd87e..886e964 100644 (file)
@@ -497,7 +497,6 @@ static int ccs811_probe(struct i2c_client *client,
                        goto err_poweroff;
                }
 
-               data->drdy_trig->dev.parent = &client->dev;
                data->drdy_trig->ops = &ccs811_trigger_ops;
                iio_trigger_set_drvdata(data->drdy_trig, indio_dev);
                indio_dev->trig = data->drdy_trig;
index 4d0d798..261c277 100644 (file)
@@ -646,7 +646,6 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
                return -ENOMEM;
        }
 
-       trig->dev.parent = dev;
        trig->ops = &scd30_trigger_ops;
        iio_trigger_set_drvdata(trig, indio_dev);
 
index c45d822..cec5e1f 100644 (file)
@@ -593,7 +593,6 @@ static int adxrs290_probe_trigger(struct iio_dev *indio_dev)
        if (!st->dready_trig)
                return -ENOMEM;
 
-       st->dready_trig->dev.parent = &st->spi->dev;
        st->dready_trig->ops = &adxrs290_trigger_ops;
        iio_trigger_set_drvdata(st->dready_trig, indio_dev);
 
index 029ef4c..b11ebd9 100644 (file)
@@ -1148,14 +1148,12 @@ int bmg160_core_probe(struct device *dev, struct regmap *regmap, int irq,
                if (!data->motion_trig)
                        return -ENOMEM;
 
-               data->dready_trig->dev.parent = dev;
                data->dready_trig->ops = &bmg160_trigger_ops;
                iio_trigger_set_drvdata(data->dready_trig, indio_dev);
                ret = iio_trigger_register(data->dready_trig);
                if (ret)
                        return ret;
 
-               data->motion_trig->dev.parent = dev;
                data->motion_trig->ops = &bmg160_trigger_ops;
                iio_trigger_set_drvdata(data->motion_trig, indio_dev);
                ret = iio_trigger_register(data->motion_trig);
index 129eead..1a20c6b 100644 (file)
@@ -875,7 +875,6 @@ static int fxas21002c_trigger_probe(struct fxas21002c_data *data)
        if (ret < 0)
                return ret;
 
-       data->dready_trig->dev.parent = dev;
        data->dready_trig->ops = &fxas21002c_trigger_ops;
        iio_trigger_set_drvdata(data->dready_trig, indio_dev);
 
index 38734e4..1fa8d51 100644 (file)
@@ -531,7 +531,6 @@ static int afe4403_probe(struct spi_device *spi)
                iio_trigger_set_drvdata(afe->trig, indio_dev);
 
                afe->trig->ops = &afe4403_trigger_ops;
-               afe->trig->dev.parent = afe->dev;
 
                ret = iio_trigger_register(afe->trig);
                if (ret) {
index 61fe493..e1476bf 100644 (file)
@@ -538,7 +538,6 @@ static int afe4404_probe(struct i2c_client *client,
                iio_trigger_set_drvdata(afe->trig, indio_dev);
 
                afe->trig->ops = &afe4404_trigger_ops;
-               afe->trig->dev.parent = afe->dev;
 
                ret = iio_trigger_register(afe->trig);
                if (ret) {
index 95e5691..f29692b 100644 (file)
@@ -135,7 +135,6 @@ int hts221_allocate_trigger(struct iio_dev *iio_dev)
 
        iio_trigger_set_drvdata(hw->trig, iio_dev);
        hw->trig->ops = &hts221_trigger_ops;
-       hw->trig->dev.parent = hw->dev;
        iio_dev->trig = iio_trigger_get(hw->trig);
 
        return devm_iio_trigger_register(hw->dev, hw->trig);
index 4377047..fc5a60f 100644 (file)
@@ -1268,7 +1268,6 @@ static struct iio_trigger *kmx61_trigger_setup(struct kmx61_data *data,
        if (!trig)
                return ERR_PTR(-ENOMEM);
 
-       trig->dev.parent = &data->client->dev;
        trig->ops = &kmx61_trigger_ops;
        iio_trigger_set_drvdata(trig, indio_dev);
 
index 31224a3..033578f 100644 (file)
@@ -990,7 +990,6 @@ static int rpr0521_probe(struct i2c_client *client,
                        ret = -ENOMEM;
                        goto err_pm_disable;
                }
-               data->drdy_trigger0->dev.parent = indio_dev->dev.parent;
                data->drdy_trigger0->ops = &rpr0521_trigger_ops;
                indio_dev->available_scan_masks = rpr0521_available_scan_masks;
                iio_trigger_set_drvdata(data->drdy_trigger0, indio_dev);
index b304801..9b5c998 100644 (file)
@@ -1247,7 +1247,6 @@ static int si1145_probe_trigger(struct iio_dev *indio_dev)
        if (!trig)
                return -ENOMEM;
 
-       trig->dev.parent = &client->dev;
        trig->ops = &si1145_trigger_ops;
        iio_trigger_set_drvdata(trig, indio_dev);
 
index 1055594..41a2ce5 100644 (file)
@@ -210,7 +210,6 @@ static int st_uvis25_allocate_trigger(struct iio_dev *iio_dev)
                return -ENOMEM;
 
        iio_trigger_set_drvdata(hw->trig, iio_dev);
-       hw->trig->dev.parent = dev;
 
        return devm_iio_trigger_register(dev, hw->trig);
 }
index fff4b36..2f7916f 100644 (file)
@@ -1002,7 +1002,6 @@ static int vcnl4010_probe_trigger(struct iio_dev *indio_dev)
        if (!trigger)
                return -ENOMEM;
 
-       trigger->dev.parent = &client->dev;
        trigger->ops = &vcnl4010_trigger_ops;
        iio_trigger_set_drvdata(trigger, indio_dev);
 
index 73a28e3..ae87740 100644 (file)
@@ -511,7 +511,6 @@ static int vcnl4035_probe_trigger(struct iio_dev *indio_dev)
        if (!data->drdy_trigger0)
                return -ENOMEM;
 
-       data->drdy_trigger0->dev.parent = indio_dev->dev.parent;
        data->drdy_trigger0->ops = &vcnl4035_trigger_ops;
        iio_trigger_set_drvdata(data->drdy_trigger0, indio_dev);
        ret = devm_iio_trigger_register(indio_dev->dev.parent,
index b2f3129..00f9766 100644 (file)
@@ -922,7 +922,6 @@ int bmc150_magn_probe(struct device *dev, struct regmap *regmap,
                        goto err_poweroff;
                }
 
-               data->dready_trig->dev.parent = dev;
                data->dready_trig->ops = &bmc150_magn_trigger_ops;
                iio_trigger_set_drvdata(data->dready_trig, indio_dev);
                ret = iio_trigger_register(data->dready_trig);
index 7242897..dd811da 100644 (file)
@@ -579,7 +579,6 @@ int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq)
                if (!data->drdy_trig)
                        return -ENOMEM;
 
-               data->drdy_trig->dev.parent = dev;
                ret = devm_iio_trigger_register(dev, data->drdy_trig);
                if (ret < 0)
                        return ret;
index 2cecbe0..70adff6 100644 (file)
@@ -1413,7 +1413,6 @@ static int zpa2326_init_managed_trigger(struct device          *parent,
                return -ENOMEM;
 
        /* Basic setup. */
-       trigger->dev.parent = parent;
        trigger->ops = &zpa2326_trigger_ops;
 
        private->trigger = trigger;
index 37fd0b6..394c2af 100644 (file)
@@ -1453,7 +1453,6 @@ static int sx9310_probe(struct i2c_client *client)
                if (!data->trig)
                        return -ENOMEM;
 
-               data->trig->dev.parent = dev;
                data->trig->ops = &sx9310_trigger_ops;
                iio_trigger_set_drvdata(data->trig, indio_dev);
 
index 67353d3..a87f4a8 100644 (file)
@@ -950,7 +950,6 @@ static int sx9500_probe(struct i2c_client *client,
                if (!data->trig)
                        return -ENOMEM;
 
-               data->trig->dev.parent = &client->dev;
                data->trig->ops = &sx9500_trigger_ops;
                iio_trigger_set_drvdata(data->trig, indio_dev);