thermal/drivers/rcar_gen3_thermal: Fix coefficient calculations
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Sat, 5 Jun 2021 08:52:11 +0000 (10:52 +0200)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 14 Jun 2021 17:02:55 +0000 (19:02 +0200)
The fixed value of 157 used in the calculations are only correct for
M3-W, on other Gen3 SoC it should be 167. The constant can be derived
correctly from the static TJ_3 constant and the SoC specific TJ_1 value.
Update the calculation be correct on all Gen3 SoCs.

Fixes: 4eb39f79ef44 ("thermal: rcar_gen3_thermal: Update value of Tj_1")
Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210605085211.564909-1-niklas.soderlund+renesas@ragnatech.se
drivers/thermal/rcar_gen3_thermal.c

index e1e4123..1a60adb 100644 (file)
@@ -143,7 +143,7 @@ static void rcar_gen3_thermal_calc_coefs(struct rcar_gen3_thermal_tsc *tsc,
         * Division is not scaled in BSP and if scaled it might overflow
         * the dividend (4095 * 4095 << 14 > INT_MAX) so keep it unscaled
         */
-       tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * 157)
+       tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * (ths_tj_1 - TJ_3))
                     / (ptat[0] - ptat[2])) + FIXPT_INT(TJ_3);
 
        tsc->coef.a1 = FIXPT_DIV(FIXPT_INT(thcode[1] - thcode[2]),