ata: sata_rcar: make sata_rcar_ata_devchk() return 'bool'
authorSergey Shtylyov <s.shtylyov@omp.ru>
Wed, 9 Feb 2022 21:46:30 +0000 (00:46 +0300)
committerDamien Le Moal <damien.lemoal@opensource.wdc.com>
Sat, 19 Feb 2022 02:18:43 +0000 (11:18 +0900)
sata_rcar_ata_devchk() returns 1 if a device is present, 0 if not --
the 'bool' type clearly fits better here than 'unsigned int'...

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
drivers/ata/sata_rcar.c

index be8bfef..20263c1 100644 (file)
@@ -283,8 +283,7 @@ static void sata_rcar_dev_select(struct ata_port *ap, unsigned int device)
        ata_sff_pause(ap);      /* needed; also flushes, for mmio */
 }
 
-static unsigned int sata_rcar_ata_devchk(struct ata_port *ap,
-                                        unsigned int device)
+static bool sata_rcar_ata_devchk(struct ata_port *ap, unsigned int device)
 {
        struct ata_ioports *ioaddr = &ap->ioaddr;
        u8 nsect, lbal;
@@ -304,9 +303,9 @@ static unsigned int sata_rcar_ata_devchk(struct ata_port *ap,
        lbal  = ioread32(ioaddr->lbal_addr);
 
        if (nsect == 0x55 && lbal == 0xaa)
-               return 1;       /* found a device */
+               return true;    /* found a device */
 
-       return 0;               /* nothing found */
+       return false;           /* nothing found */
 }
 
 static int sata_rcar_wait_after_reset(struct ata_link *link,