projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0c68387
)
pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()
author
Zou Wei
<zou_wei@huawei.com>
Tue, 8 Jun 2021 06:34:08 +0000
(14:34 +0800)
committer
Linus Walleij
<linus.walleij@linaro.org>
Wed, 9 Jun 2021 13:30:44 +0000
(15:30 +0200)
Add the missing unlock before return from function mcp23s08_irq()
in the error handling case.
v1-->v2:
remove the "return IRQ_HANDLED" line
Fixes:
897120d41e7a
("pinctrl: mcp23s08: fix race condition in irq handler")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Link:
https://lore.kernel.org/r/1623134048-56051-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-mcp23s08.c
patch
|
blob
|
history
diff --git
a/drivers/pinctrl/pinctrl-mcp23s08.c
b/drivers/pinctrl/pinctrl-mcp23s08.c
index
799d596
..
d025957
100644
(file)
--- a/
drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/
drivers/pinctrl/pinctrl-mcp23s08.c
@@
-353,7
+353,7
@@
static irqreturn_t mcp23s08_irq(int irq, void *data)
if (intf == 0) {
/* There is no interrupt pending */
-
return IRQ_HANDLED
;
+
goto unlock
;
}
if (mcp_read(mcp, MCP_INTCAP, &intcap))