s390/drivers: fix proc/debugfs file permissions

Remove write permissions for fops without a write callback.

Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

diff --git a/drivers/s390/block/dasd_proc.c b/drivers/s390/block/dasd_proc.c
index 5cb80c6..1770b99 100644 (file)
--- a/drivers/s390/block/dasd_proc.c
+++ b/drivers/s390/block/dasd_proc.c
@@ -339,8 +339,7 @@ dasd_proc_init(void)
        dasd_proc_root_entry = proc_mkdir("dasd", NULL);
        if (!dasd_proc_root_entry)
                goto out_nodasd;
-       dasd_devices_entry = proc_create_seq("devices",
-                                        S_IFREG | S_IRUGO | S_IWUSR,
+       dasd_devices_entry = proc_create_seq("devices", 0444,
                                         dasd_proc_root_entry,
                                         &dasd_devices_seq_ops);
        if (!dasd_devices_entry)

diff --git a/drivers/s390/char/tape_proc.c b/drivers/s390/char/tape_proc.c
index 32a14ee..2238d9d 100644 (file)
--- a/drivers/s390/char/tape_proc.c
+++ b/drivers/s390/char/tape_proc.c
@@ -111,11 +111,8 @@ static const struct seq_operations tape_proc_seq = {
 void
 tape_proc_init(void)
 {
-       tape_proc_devices = proc_create_seq("tapedevices",
-                       S_IFREG | S_IRUGO | S_IWUSR, NULL,  &tape_proc_seq);
-       if (tape_proc_devices == NULL) {
-               return;
-       }
+       tape_proc_devices = proc_create_seq("tapedevices", 0444, NULL,
+                                           &tape_proc_seq);
 }
 
 /*

diff --git a/drivers/s390/cio/qdio_debug.c b/drivers/s390/cio/qdio_debug.c
index 040061f..d2f98e5 100644 (file)
--- a/drivers/s390/cio/qdio_debug.c
+++ b/drivers/s390/cio/qdio_debug.c
@@ -293,7 +293,7 @@ static void setup_debugfs_entry(struct qdio_q *q)
        snprintf(name, QDIO_DEBUGFS_NAME_LEN, "%s_%d",
                 q->is_input_q ? "input" : "output",
                 q->nr);
-       q->debugfs_q = debugfs_create_file(name, S_IFREG | S_IRUGO | S_IWUSR,
+       q->debugfs_q = debugfs_create_file(name, 0444,
                                q->irq_ptr->debugfs_dev, q, &qstat_fops);
        if (IS_ERR(q->debugfs_q))
                q->debugfs_q = NULL;