HID: lenovo: Set LEDs max_brightness value
authorHans de Goede <hdegoede@redhat.com>
Sun, 4 Apr 2021 08:04:28 +0000 (10:04 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 7 Apr 2021 10:48:19 +0000 (12:48 +0200)
The LEDs can only by turned on/off, so max_brightness should be set to 1.
Without this the max_brightness sysfs-attribute will report 255 which is
wrong.

Reviewed-by: Marek BehĂșn <kabel@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-lenovo.c

index 1b8dd85..6687626 100644 (file)
@@ -822,6 +822,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
 
        data->led_mute.name = name_mute;
        data->led_mute.brightness_set_blocking = lenovo_led_brightness_set;
+       data->led_mute.max_brightness = 1;
        data->led_mute.flags = LED_HW_PLUGGABLE;
        data->led_mute.dev = &hdev->dev;
        ret = led_classdev_register(&hdev->dev, &data->led_mute);
@@ -830,6 +831,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
 
        data->led_micmute.name = name_micm;
        data->led_micmute.brightness_set_blocking = lenovo_led_brightness_set;
+       data->led_micmute.max_brightness = 1;
        data->led_micmute.flags = LED_HW_PLUGGABLE;
        data->led_micmute.dev = &hdev->dev;
        ret = led_classdev_register(&hdev->dev, &data->led_micmute);