ALSA: x86: Fix driver name string overflow
authorTakashi Iwai <tiwai@suse.de>
Tue, 7 Feb 2017 11:14:04 +0000 (12:14 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 7 Feb 2017 11:33:20 +0000 (12:33 +0100)
The driver sets card->driver name string over its size (16 bytes).
Shorten the name string to fit with it.

Also, set more verbose string to card->shortname and ->longname.
This doesn't have to be identical with card->driver at all.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/x86/intel_hdmi_audio.c
sound/x86/intel_hdmi_lpe_audio.h

index 8506a3d..dd7944c 100644 (file)
@@ -1694,7 +1694,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
        ctx->card = card;
        ctx->aes_bits = SNDRV_PCM_DEFAULT_CON_SPDIF;
        strcpy(card->driver, INTEL_HAD);
-       strcpy(card->shortname, INTEL_HAD);
+       strcpy(card->shortname, "Intel HDMI/DP LPE Audio");
+       strcpy(card->longname, "Intel HDMI/DP LPE Audio");
 
        ctx->irq = -1;
        ctx->tmds_clock_speed = DIS_SAMPLE_RATE_148_5;
index ca4212d..48cab1b 100644 (file)
@@ -57,7 +57,7 @@
 #define HAD_REG_WIDTH          0x08
 #define HAD_MAX_HW_BUFS                0x04
 #define HAD_MAX_DIP_WORDS              16
-#define INTEL_HAD              "IntelHdmiLpeAudio"
+#define INTEL_HAD              "HdmiLpeAudio"
 
 /* DP Link Rates */
 #define DP_2_7_GHZ                     270000