thermal: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:26 +0000 (08:47 -0600)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 30 Mar 2023 17:26:44 +0000 (19:26 +0200)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/cpufreq_cooling.c
drivers/thermal/imx8mm_thermal.c
drivers/thermal/imx_thermal.c
drivers/thermal/ti-soc-thermal/ti-thermal-common.c

index 9f8b438..4608555 100644 (file)
@@ -633,7 +633,7 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy)
                return NULL;
        }
 
-       if (of_find_property(np, "#cooling-cells", NULL)) {
+       if (of_property_present(np, "#cooling-cells")) {
                struct em_perf_domain *em = em_cpu_get(policy->cpu);
 
                cdev = __cpufreq_cooling_register(np, policy, em);
index e0de6ac..d8005e9 100644 (file)
@@ -282,7 +282,7 @@ static int imx8mm_tmu_probe_set_calib(struct platform_device *pdev,
         * strongly recommended to update such old DTs to get correct
         * temperature compensation values for each SoC.
         */
-       if (!of_find_property(pdev->dev.of_node, "nvmem-cells", NULL)) {
+       if (!of_property_present(pdev->dev.of_node, "nvmem-cells")) {
                dev_warn(dev,
                         "No OCOTP nvmem reference found, SoC-specific calibration not loaded. Please update your DT.\n");
                return 0;
index c313697..dbc1649 100644 (file)
@@ -571,7 +571,7 @@ static int imx_thermal_register_legacy_cooling(struct imx_thermal_data *data)
 
        np = of_get_cpu_node(data->policy->cpu, NULL);
 
-       if (!np || !of_find_property(np, "#cooling-cells", NULL)) {
+       if (!np || !of_property_present(np, "#cooling-cells")) {
                data->cdev = cpufreq_cooling_register(data->policy);
                if (IS_ERR(data->cdev)) {
                        ret = PTR_ERR(data->cdev);
@@ -648,7 +648,7 @@ static int imx_thermal_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, data);
 
-       if (of_find_property(pdev->dev.of_node, "nvmem-cells", NULL)) {
+       if (of_property_present(pdev->dev.of_node, "nvmem-cells")) {
                ret = imx_init_from_nvmem_cells(pdev);
                if (ret)
                        return dev_err_probe(&pdev->dev, ret,
index 0c89140..938ddf4 100644 (file)
@@ -223,7 +223,7 @@ int ti_thermal_register_cpu_cooling(struct ti_bandgap *bgp, int id)
         * using DT, then it must be aware that the cooling device
         * loading has to happen via cpufreq driver.
         */
-       if (of_find_property(np, "#thermal-sensor-cells", NULL))
+       if (of_property_present(np, "#thermal-sensor-cells"))
                return 0;
 
        data = ti_bandgap_get_sensor_data(bgp, id);