watchdog: da9055_wdt: Use 'dev' instead of dereferencing it repeatedly
authorGuenter Roeck <linux@roeck-us.net>
Mon, 8 Apr 2019 19:38:34 +0000 (12:38 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:16 +0000 (21:02 +0200)
Introduce local variable 'struct device *dev' and use it instead of
dereferencing it repeatedly.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

Cc: Support Opensource <support.opensource@diasemi.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/da9055_wdt.c

index 26a5b29..389a4bd 100644 (file)
@@ -119,13 +119,13 @@ static const struct watchdog_ops da9055_wdt_ops = {
 
 static int da9055_wdt_probe(struct platform_device *pdev)
 {
-       struct da9055 *da9055 = dev_get_drvdata(pdev->dev.parent);
+       struct device *dev = &pdev->dev;
+       struct da9055 *da9055 = dev_get_drvdata(dev->parent);
        struct da9055_wdt_data *driver_data;
        struct watchdog_device *da9055_wdt;
        int ret;
 
-       driver_data = devm_kzalloc(&pdev->dev, sizeof(*driver_data),
-                                  GFP_KERNEL);
+       driver_data = devm_kzalloc(dev, sizeof(*driver_data), GFP_KERNEL);
        if (!driver_data)
                return -ENOMEM;
 
@@ -136,17 +136,17 @@ static int da9055_wdt_probe(struct platform_device *pdev)
        da9055_wdt->timeout = DA9055_DEF_TIMEOUT;
        da9055_wdt->info = &da9055_wdt_info;
        da9055_wdt->ops = &da9055_wdt_ops;
-       da9055_wdt->parent = &pdev->dev;
+       da9055_wdt->parent = dev;
        watchdog_set_nowayout(da9055_wdt, nowayout);
        watchdog_set_drvdata(da9055_wdt, driver_data);
 
        ret = da9055_wdt_stop(da9055_wdt);
        if (ret < 0) {
-               dev_err(&pdev->dev, "Failed to stop watchdog, %d\n", ret);
+               dev_err(dev, "Failed to stop watchdog, %d\n", ret);
                return ret;
        }
 
-       ret = devm_watchdog_register_device(&pdev->dev, &driver_data->wdt);
+       ret = devm_watchdog_register_device(dev, &driver_data->wdt);
        if (ret != 0)
                dev_err(da9055->dev, "watchdog_register_device() failed: %d\n",
                        ret);