f2fs: handle readonly filesystem in f2fs_ioc_shutdown()
authorChao Yu <yuchao0@huawei.com>
Mon, 8 Jun 2020 12:03:16 +0000 (20:03 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 9 Jun 2020 03:37:53 +0000 (20:37 -0700)
If mountpoint is readonly, we should allow shutdowning filesystem
successfully, this fixes issue found by generic/599 testcase of
xfstest.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c

index dfa1ac2..3268f8d 100644 (file)
@@ -2232,8 +2232,15 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg)
 
        if (in != F2FS_GOING_DOWN_FULLSYNC) {
                ret = mnt_want_write_file(filp);
-               if (ret)
+               if (ret) {
+                       if (ret == -EROFS) {
+                               ret = 0;
+                               f2fs_stop_checkpoint(sbi, false);
+                               set_sbi_flag(sbi, SBI_IS_SHUTDOWN);
+                               trace_f2fs_shutdown(sbi, in, ret);
+                       }
                        return ret;
+               }
        }
 
        switch (in) {