drm/vkms: Fix missing kmalloc allocation failure check
authorColin Ian King <colin.king@canonical.com>
Fri, 15 Jan 2021 13:09:11 +0000 (13:09 +0000)
committerMelissa Wen <melissa.srw@gmail.com>
Fri, 15 Jan 2021 20:45:07 +0000 (17:45 -0300)
Currently the kmalloc allocation for config is not being null
checked and could potentially lead to a null pointer dereference.
Fix this by adding the missing null check.

Addresses-Coverity: ("Dereference null return value")
Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115130911.71073-1-colin.king@canonical.com
drivers/gpu/drm/vkms/vkms_drv.c

index 708f7f5..2173b82 100644 (file)
@@ -188,7 +188,11 @@ out_unregister:
 
 static int __init vkms_init(void)
 {
-       struct vkms_config *config = kmalloc(sizeof(*config), GFP_KERNEL);
+       struct vkms_config *config;
+
+       config = kmalloc(sizeof(*config), GFP_KERNEL);
+       if (!config)
+               return -ENOMEM;
 
        default_config = config;