mailbox: platform-mhu: Use device-managed registration API
authorThierry Reding <treding@nvidia.com>
Thu, 20 Dec 2018 17:19:58 +0000 (18:19 +0100)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 21 Dec 2018 22:49:25 +0000 (16:49 -0600)
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.

Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/platform_mhu.c

index e13201a..d2502c5 100644 (file)
@@ -163,7 +163,7 @@ static int platform_mhu_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, mhu);
 
-       err = mbox_controller_register(&mhu->mbox);
+       err = devm_mbox_controller_register(dev, &mhu->mbox);
        if (err) {
                dev_err(dev, "Failed to register mailboxes %d\n", err);
                return err;
@@ -173,15 +173,6 @@ static int platform_mhu_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int platform_mhu_remove(struct platform_device *pdev)
-{
-       struct platform_mhu *mhu = platform_get_drvdata(pdev);
-
-       mbox_controller_unregister(&mhu->mbox);
-
-       return 0;
-}
-
 static const struct of_device_id platform_mhu_dt_ids[] = {
        { .compatible = "amlogic,meson-gxbb-mhu", },
        { /* sentinel */ },
@@ -190,7 +181,6 @@ MODULE_DEVICE_TABLE(of, platform_mhu_dt_ids);
 
 static struct platform_driver platform_mhu_driver = {
        .probe  = platform_mhu_probe,
-       .remove = platform_mhu_remove,
        .driver = {
                .name = "platform-mhu",
                .of_match_table = platform_mhu_dt_ids,