remoteproc: imx_rproc: Initialize workqueue earlier
authorPeng Fan <peng.fan@nxp.com>
Fri, 19 Jul 2024 08:36:13 +0000 (16:36 +0800)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Mon, 29 Jul 2024 15:42:07 +0000 (09:42 -0600)
Initialize workqueue before requesting mailbox channel, otherwise if
mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback
will trigger issue.

Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://lore.kernel.org/r/20240719-imx_rproc-v2-3-10d0268c7eb1@nxp.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/imx_rproc.c

index 48c48b5..9e99bb2 100644 (file)
@@ -1087,6 +1087,8 @@ static int imx_rproc_probe(struct platform_device *pdev)
                return -ENOMEM;
        }
 
+       INIT_WORK(&priv->rproc_work, imx_rproc_vq_work);
+
        ret = imx_rproc_xtr_mbox_init(rproc);
        if (ret)
                goto err_put_wkq;
@@ -1105,8 +1107,6 @@ static int imx_rproc_probe(struct platform_device *pdev)
        if (ret)
                goto err_put_scu;
 
-       INIT_WORK(&priv->rproc_work, imx_rproc_vq_work);
-
        if (rproc->state != RPROC_DETACHED)
                rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot");