[PATCH] wrong thing iounmapped (qla3xxx)
authorAl Viro <viro@ftp.linux.org.uk>
Mon, 25 Sep 2006 01:54:46 +0000 (02:54 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 25 Sep 2006 03:07:49 +0000 (20:07 -0700)
ql3xxx_probe() does ioremap and stores result in ->mem_map_registers.
On failure exit it does iounmap() of the same thing.

OTOH, ql3xxx_remove() does iounmap() of ->mmap_virt_base which is
 (a) never assigned and
 (b) never used other than in that iounmap() call.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/net/qla3xxx.c

index c184cd8..1574718 100644 (file)
@@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
                qdev->workqueue = NULL;
        }
 
-       iounmap(qdev->mmap_virt_base);
+       iounmap(qdev->mem_map_registers);
        pci_release_regions(pdev);
        pci_set_drvdata(pdev, NULL);
        free_netdev(ndev);