scsi: aacraid: Provide suggested curly braces around empty body of if()
authorLee Jones <lee.jones@linaro.org>
Mon, 13 Jul 2020 07:46:39 +0000 (08:46 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 15 Jul 2020 20:01:58 +0000 (16:01 -0400)
Fixes the following W=1 kernel build warning(s):

 drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
 drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
 368 | param->heads, param->sectors, num));
 | ^

Link: https://lore.kernel.org/r/20200713074645.126138-24-lee.jones@linaro.org
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc: "PMC-Sierra, Inc" <aacraid@pmc-sierra.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aacraid/linit.c

index a308e86..734dd6e 100644 (file)
@@ -363,9 +363,10 @@ static int aac_biosparm(struct scsi_device *sdev, struct block_device *bdev,
 
                param->cylinders = cap_to_cyls(capacity, param->heads * param->sectors);
                if (num < 4 && end_sec == param->sectors) {
-                       if (param->cylinders != saved_cylinders)
+                       if (param->cylinders != saved_cylinders) {
                                dprintk((KERN_DEBUG "Adopting geometry: heads=%d, sectors=%d from partition table %d.\n",
                                        param->heads, param->sectors, num));
+                       }
                } else if (end_head > 0 || end_sec > 0) {
                        dprintk((KERN_DEBUG "Strange geometry: heads=%d, sectors=%d in partition table %d.\n",
                                end_head + 1, end_sec, num));