drm/omap: plane: Remove redundant zpos initialisation
authorMaxime Ripard <maxime@cerno.tech>
Mon, 21 Feb 2022 09:59:10 +0000 (10:59 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Fri, 25 Feb 2022 16:56:55 +0000 (17:56 +0100)
The omap KMS driver will call drm_plane_create_zpos_property() with an
init value of the plane index and the plane type.

Since the initial value wasn't carried over in the state, the driver had
to set it again in omap_plane_reset(). However, the helpers have been
adjusted to set it properly at reset, so this is not needed anymore.

Reviewed-by: Tomi Valkeinen <tomba@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220221095918.18763-15-maxime@cerno.tech
drivers/gpu/drm/omapdrm/omap_plane.c

index e67baf9..d96bc92 100644 (file)
@@ -414,13 +414,6 @@ static void omap_plane_reset(struct drm_plane *plane)
                return;
 
        __drm_atomic_helper_plane_reset(plane, &omap_state->base);
-
-       /*
-        * Set the zpos default depending on whether we are a primary or overlay
-        * plane.
-        */
-       plane->state->zpos = plane->type == DRM_PLANE_TYPE_PRIMARY
-                          ? 0 : omap_plane->id;
        plane->state->color_encoding = DRM_COLOR_YCBCR_BT601;
        plane->state->color_range = DRM_COLOR_YCBCR_FULL_RANGE;
 }