video: fbdev: imxfb: Fix missing of_node_put in imxfb_probe
authorLv Ruyi <lv.ruyi@zte.com.cn>
Thu, 7 Apr 2022 09:01:22 +0000 (09:01 +0000)
committerHelge Deller <deller@gmx.de>
Thu, 7 Apr 2022 19:40:37 +0000 (21:40 +0200)
of_parse_phandle returns node pointer with refcount incremented,
use of_node_put() on it when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/imxfb.c

index 6828875..a2f644c 100644 (file)
@@ -925,10 +925,12 @@ static int imxfb_probe(struct platform_device *pdev)
                                sizeof(struct imx_fb_videomode), GFP_KERNEL);
                if (!fbi->mode) {
                        ret = -ENOMEM;
+                       of_node_put(display_np);
                        goto failed_of_parse;
                }
 
                ret = imxfb_of_read_mode(&pdev->dev, display_np, fbi->mode);
+               of_node_put(display_np);
                if (ret)
                        goto failed_of_parse;
        }