media: tvp5150: fix irq_request error path during probe
authorMarco Felsch <m.felsch@pengutronix.de>
Tue, 18 Sep 2018 13:14:46 +0000 (09:14 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 5 Dec 2018 09:40:10 +0000 (04:40 -0500)
Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
introduced the interrupt handling. But we have to free the
v4l2_ctrl_handler before we can return the error code.

Fixes: 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/tvp5150.c

index 0e91b99..eaddd97 100644 (file)
@@ -1790,7 +1790,7 @@ static int tvp5150_probe(struct i2c_client *c,
                                                tvp5150_isr, IRQF_TRIGGER_HIGH |
                                                IRQF_ONESHOT, "tvp5150", core);
                if (res)
-                       return res;
+                       goto err;
        }
 
        res = v4l2_async_register_subdev(sd);