rtlwifi: Add rate section and its related definition and comment
authorPing-Ke Shih <pkshih@realtek.com>
Mon, 29 Jan 2018 03:26:36 +0000 (11:26 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 27 Feb 2018 16:15:20 +0000 (18:15 +0200)
Add comments to make it to be easier to understand, and add compile time
assertions.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/base.c
drivers/net/wireless/realtek/rtlwifi/wifi.h

index c000c85..6db3389 100644 (file)
@@ -2647,6 +2647,9 @@ EXPORT_SYMBOL_GPL(rtl_global_var);
 static int __init rtl_core_module_init(void)
 {
        BUILD_BUG_ON(TX_PWR_BY_RATE_NUM_RATE < TX_PWR_BY_RATE_NUM_SECTION);
+       BUILD_BUG_ON(MAX_RATE_SECTION_NUM != MAX_RATE_SECTION);
+       BUILD_BUG_ON(MAX_BASE_NUM_IN_PHY_REG_PG_24G != MAX_RATE_SECTION);
+       BUILD_BUG_ON(MAX_BASE_NUM_IN_PHY_REG_PG_5G != (MAX_RATE_SECTION - 1));
 
        if (rtl_rate_control_register())
                pr_err("rtl: Unable to register rtl_rc, use default RC !!\n");
index 29c1289..8dba4d9 100644 (file)
@@ -164,7 +164,7 @@ enum rtl8192c_h2c_cmd {
 #define MAX_TX_COUNT                   4
 #define MAX_REGULATION_NUM             4
 #define MAX_RF_PATH_NUM                        4
-#define MAX_RATE_SECTION_NUM           6
+#define MAX_RATE_SECTION_NUM           6       /* = MAX_RATE_SECTION */
 #define MAX_2_4G_BANDWIDTH_NUM         4
 #define MAX_5G_BANDWIDTH_NUM           4
 #define        MAX_RF_PATH                     4
@@ -175,8 +175,8 @@ enum rtl8192c_h2c_cmd {
 #define TX_PWR_BY_RATE_NUM_RF          4
 #define TX_PWR_BY_RATE_NUM_SECTION     12
 #define TX_PWR_BY_RATE_NUM_RATE                84 /* >= TX_PWR_BY_RATE_NUM_SECTION */
-#define MAX_BASE_NUM_IN_PHY_REG_PG_24G  6
-#define MAX_BASE_NUM_IN_PHY_REG_PG_5G  5
+#define MAX_BASE_NUM_IN_PHY_REG_PG_24G 6  /* MAX_RATE_SECTION */
+#define MAX_BASE_NUM_IN_PHY_REG_PG_5G  5  /* MAX_RATE_SECTION -1 */
 
 #define BUFDESC_SEG_NUM                1 /* 0:2 seg, 1: 4 seg, 2: 8 seg */
 
@@ -272,6 +272,7 @@ enum rate_section {
        HT_MCS8_MCS15,
        VHT_1SSMCS0_1SSMCS9,
        VHT_2SSMCS0_2SSMCS9,
+       MAX_RATE_SECTION,
 };
 
 enum intf_type {