scsi: storvsc: Handle additional SRB status values
authorMichael Kelley <mikelley@microsoft.com>
Fri, 25 Aug 2023 17:21:24 +0000 (10:21 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2023 21:10:02 +0000 (17:10 -0400)
Testing of virtual Fibre Channel devices under Hyper-V has shown additional
SRB status values being returned for various error cases.  Because these
SRB status values are not recognized by storvsc, the I/O operations are not
flagged as an error. Requests are treated as if they completed normally but
with zero data transferred, which can cause a flood of retries.

Add definitions for these SRB status values and handle them like other
error statuses from the Hyper-V host.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/1692984084-95105-1-git-send-email-mikelley@microsoft.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/storvsc_drv.c

index 047ffaf..0686255 100644 (file)
@@ -316,6 +316,9 @@ enum storvsc_request_type {
 #define SRB_STATUS_ABORTED             0x02
 #define SRB_STATUS_ERROR               0x04
 #define SRB_STATUS_INVALID_REQUEST     0x06
+#define SRB_STATUS_TIMEOUT             0x09
+#define SRB_STATUS_SELECTION_TIMEOUT   0x0A
+#define SRB_STATUS_BUS_RESET           0x0E
 #define SRB_STATUS_DATA_OVERRUN                0x12
 #define SRB_STATUS_INVALID_LUN         0x20
 #define SRB_STATUS_INTERNAL_ERROR      0x30
@@ -981,6 +984,10 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
        case SRB_STATUS_ABORTED:
        case SRB_STATUS_INVALID_REQUEST:
        case SRB_STATUS_INTERNAL_ERROR:
+       case SRB_STATUS_TIMEOUT:
+       case SRB_STATUS_SELECTION_TIMEOUT:
+       case SRB_STATUS_BUS_RESET:
+       case SRB_STATUS_DATA_OVERRUN:
                if (vm_srb->srb_status & SRB_STATUS_AUTOSENSE_VALID) {
                        /* Check for capacity change */
                        if ((asc == 0x2a) && (ascq == 0x9)) {