drm/i915/fbc: Pimp the FBC debugfs output
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 24 Nov 2021 11:36:52 +0000 (13:36 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 3 Dec 2021 17:15:01 +0000 (19:15 +0200)
Now that each plane tracks its own no_fbc_reason we can print that
out in debugfs, and we can also show which plane is currently
selected for FBC duty.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211124113652.22090-21-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_fbc.c

index 58a5d44..f5d16c1 100644 (file)
@@ -1688,8 +1688,11 @@ static int intel_fbc_debugfs_status_show(struct seq_file *m, void *unused)
 {
        struct intel_fbc *fbc = m->private;
        struct drm_i915_private *i915 = fbc->i915;
+       struct intel_plane *plane;
        intel_wakeref_t wakeref;
 
+       drm_modeset_lock_all(&i915->drm);
+
        wakeref = intel_runtime_pm_get(&i915->runtime_pm);
        mutex_lock(&fbc->lock);
 
@@ -1701,9 +1704,24 @@ static int intel_fbc_debugfs_status_show(struct seq_file *m, void *unused)
                seq_printf(m, "FBC disabled: %s\n", fbc->no_fbc_reason);
        }
 
+       for_each_intel_plane(&i915->drm, plane) {
+               const struct intel_plane_state *plane_state =
+                       to_intel_plane_state(plane->base.state);
+
+               if (plane->fbc != fbc)
+                       continue;
+
+               seq_printf(m, "%c [PLANE:%d:%s]: %s\n",
+                          fbc->state.plane == plane ? '*' : ' ',
+                          plane->base.base.id, plane->base.name,
+                          plane_state->no_fbc_reason ?: "FBC possible");
+       }
+
        mutex_unlock(&fbc->lock);
        intel_runtime_pm_put(&i915->runtime_pm, wakeref);
 
+       drm_modeset_unlock_all(&i915->drm);
+
        return 0;
 }