iio: light: tsl2591: fix some signedness bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 14 May 2021 13:10:07 +0000 (16:10 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 17 May 2021 13:10:24 +0000 (14:10 +0100)
These variables need to be int for the error handling to work.

Fixes: 2335f0d7c790 ("iio: light: Added AMS tsl2591 driver implementation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YJ52r1XZ44myD9Xx@mwanda
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/tsl2591.c

index 2bdae38..26e3cb6 100644 (file)
@@ -213,7 +213,7 @@ static int tsl2591_gain_to_multiplier(const u8 als_gain)
        }
 }
 
-static u8 tsl2591_multiplier_to_gain(const u32 multiplier)
+static int tsl2591_multiplier_to_gain(const u32 multiplier)
 {
        switch (multiplier) {
        case TSL2591_CTRL_ALS_LOW_GAIN_MULTIPLIER:
@@ -783,8 +783,8 @@ static int tsl2591_write_raw(struct iio_dev *indio_dev,
                             int val, int val2, long mask)
 {
        struct tsl2591_chip *chip = iio_priv(indio_dev);
-       u32 int_time;
-       u8 gain;
+       int int_time;
+       int gain;
        int ret;
 
        mutex_lock(&chip->als_mutex);