staging: rtl8188eu: convert pr_info call to dev_err call ODM_RAStateCheck
authorPhillip Potter <phil@philpotter.co.uk>
Tue, 25 May 2021 21:48:13 +0000 (22:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 May 2021 10:31:07 +0000 (12:31 +0200)
Introduce logic to extract struct device pointer from passed in struct
odm_dm_struct pointer argument, and use this to call dev_err instead of
pr_info. As this is an error state if this line is reached, this is not
just information. Also, this is a driver, so dev_err is more
appropriate.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210525214813.6362-1-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/odm.c

index b800d0c..8348e02 100644 (file)
@@ -808,6 +808,7 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate
        u8 HighRSSIThreshForRA = pRA->HighRSSIThresh;
        u8 LowRSSIThreshForRA = pRA->LowRSSIThresh;
        u8 RATRState;
+       struct device *dev = dvobj_to_dev(adapter_to_dvobj(pDM_Odm->Adapter));
 
        /*  Threshold Adjustment: */
        /*  when RSSI state trends to go up one or two levels, make sure RSSI is high enough. */
@@ -824,7 +825,7 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate
                LowRSSIThreshForRA += GoUpGap;
                break;
        default:
-               pr_info("%s(): wrong rssi level setting %d!\n", __func__, *pRATRState);
+               dev_err(dev, "%s(): wrong rssi level setting %d!\n", __func__, *pRATRState);
                break;
        }