ext4: drop duplicate ea_inode handling in ext4_xattr_block_set()

ext4_xattr_block_set() drops ea_inode reference in two places. Handling
it just under the 'cleanup' label is enough so drop the second
occurence.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240209112107.10585-3-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 146690c..b67a176 100644 (file)
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -2158,17 +2158,6 @@ getblk_failed:
                                                      ENTRY(header(s->base)+1));
                        if (error)
                                goto getblk_failed;
-                       if (ea_inode) {
-                               /* Drop the extra ref on ea_inode. */
-                               error = ext4_xattr_inode_dec_ref(handle,
-                                                                ea_inode);
-                               if (error)
-                                       ext4_warning_inode(ea_inode,
-                                                          "dec ref error=%d",
-                                                          error);
-                               iput(ea_inode);
-                               ea_inode = NULL;
-                       }
 
                        lock_buffer(new_bh);
                        error = ext4_journal_get_create_access(handle, sb,