f2fs: ensure only power of 2 zone sizes are allowed
authorLuis Chamberlain <mcgrof@kernel.org>
Wed, 27 Apr 2022 16:02:54 +0000 (18:02 +0200)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 6 May 2022 17:18:12 +0000 (10:18 -0700)
F2FS zoned support has power of 2 zone size assumption in many places
such as in __f2fs_issue_discard_zone, init_blkz_info. As the power of 2
requirement has been removed from the block layer, explicitly add a
condition in f2fs to allow only power of 2 zone size devices.

This condition will be relaxed once those calculation based on power of
2 is made generic.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/super.c

index df232ec..d06a577 100644 (file)
@@ -3658,6 +3658,10 @@ static int init_blkz_info(struct f2fs_sb_info *sbi, int devi)
                return 0;
 
        zone_sectors = bdev_zone_sectors(bdev);
+       if (!is_power_of_2(zone_sectors)) {
+               f2fs_err(sbi, "F2FS does not support non power of 2 zone sizes\n");
+               return -EINVAL;
+       }
 
        if (sbi->blocks_per_blkz && sbi->blocks_per_blkz !=
                                SECTOR_TO_BLOCK(zone_sectors))