drm/amd/display: Change MPC Tree visual confirm colours
authorJoshua Aberback <joshua.aberback@amd.com>
Thu, 17 Oct 2024 19:56:30 +0000 (15:56 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 28 Oct 2024 20:36:35 +0000 (16:36 -0400)
[Why]
MPC background colours that use fractional components look different if
MPC OGAM is in use vs in bypass mode. The current red and orange colours
look very similar when OGAM is in bypass, so the colours need to change
to be consistently very easy to tell apart.

[How]
Use colours that only have 0 or MAX values in each component

Reviewed-by: Alvin Lee <alvin.lee2@amd.com>
Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c

index 2fdcf8d..0419ee7 100644 (file)
@@ -312,11 +312,11 @@ void get_mpctree_visual_confirm_color(
 {
        const struct tg_color pipe_colors[6] = {
                        {MAX_TG_COLOR_VALUE, 0, 0}, /* red */
-                       {MAX_TG_COLOR_VALUE, MAX_TG_COLOR_VALUE / 4, 0}, /* orange */
                        {MAX_TG_COLOR_VALUE, MAX_TG_COLOR_VALUE, 0}, /* yellow */
                        {0, MAX_TG_COLOR_VALUE, 0}, /* green */
+                       {0, MAX_TG_COLOR_VALUE, MAX_TG_COLOR_VALUE}, /* cyan */
                        {0, 0, MAX_TG_COLOR_VALUE}, /* blue */
-                       {MAX_TG_COLOR_VALUE / 2, 0, MAX_TG_COLOR_VALUE / 2}, /* purple */
+                       {MAX_TG_COLOR_VALUE, 0, MAX_TG_COLOR_VALUE}, /* magenta */
        };
 
        struct pipe_ctx *top_pipe = pipe_ctx;