HID: amd_sfh: Correct the structure fields
authorBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Tue, 11 Apr 2023 16:10:24 +0000 (21:40 +0530)
committerJiri Kosina <jkosina@suse.cz>
Thu, 13 Apr 2023 13:55:22 +0000 (15:55 +0200)
Misinterpreted sfh_cmd_base structure member fields. Therefore, adjust
the structure member fields accordingly to reflect functionality.

Fixes: 93ce5e0231d7 ("HID: amd_sfh: Implement SFH1.1 functionality")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.h

index ae47a36..a3e0ec2 100644 (file)
@@ -33,9 +33,9 @@ struct sfh_cmd_base {
                struct {
                        u32 sensor_id           : 4;
                        u32 cmd_id              : 4;
-                       u32 sub_cmd_id          : 6;
-                       u32 length              : 12;
-                       u32 rsvd                : 5;
+                       u32 sub_cmd_id          : 8;
+                       u32 sub_cmd_value       : 12;
+                       u32 rsvd                : 3;
                        u32 intr_disable        : 1;
                } cmd;
        };