EDAC/amd64: Do not warn when removing instances
authorBorislav Petkov <bp@suse.de>
Fri, 17 Jan 2020 11:30:20 +0000 (12:30 +0100)
committerBorislav Petkov <bp@suse.de>
Fri, 17 Jan 2020 12:00:06 +0000 (13:00 +0100)
On machines which do not populate all nodes with DIMMs, the driver
doesn't initialize an instance there. However, the instance removal
remove_one_instance() path will warn unconditionally, which is wrong.

Remove the WARN_ON() even if the warning is innocent because it causes a
splat in dmesg.

Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200117115939.5524-1-bp@alien8.de
drivers/edac/amd64_edac.c

index 428ce98..d2a6d33 100644 (file)
@@ -3573,9 +3573,6 @@ static void remove_one_instance(unsigned int nid)
        struct mem_ctl_info *mci;
        struct amd64_pvt *pvt;
 
-       mci = find_mci_by_dev(&F3->dev);
-       WARN_ON(!mci);
-
        /* Remove from EDAC CORE tracking list */
        mci = edac_mc_del_mc(&F3->dev);
        if (!mci)