accel/ivpu: Don't allocate preemption buffers when MIP is disabled
authorKarol Wachowski <karol.wachowski@intel.com>
Thu, 17 Oct 2024 14:58:14 +0000 (16:58 +0200)
committerJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Wed, 30 Oct 2024 09:22:09 +0000 (10:22 +0100)
Do not allocate preemption buffers when Mid Inference Preemption (MIP)
is disabled through test mode.

Rename IVPU_TEST_MODE_PREEMPTION_DISABLE to IVPU_TEST_MODE_MIP_DISABLE
to better describe that this test mode only disables MIP - job level
preemption will still occur.

Signed-off-by: Karol Wachowski <karol.wachowski@intel.com>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241017145817.121590-9-jacek.lawrynowicz@linux.intel.com
drivers/accel/ivpu/ivpu_drv.h
drivers/accel/ivpu/ivpu_job.c

index 8e79d78..3fdff3f 100644 (file)
@@ -197,7 +197,7 @@ extern bool ivpu_force_snoop;
 #define IVPU_TEST_MODE_NULL_SUBMISSION    BIT(2)
 #define IVPU_TEST_MODE_D0I3_MSG_DISABLE   BIT(4)
 #define IVPU_TEST_MODE_D0I3_MSG_ENABLE    BIT(5)
-#define IVPU_TEST_MODE_PREEMPTION_DISABLE BIT(6)
+#define IVPU_TEST_MODE_MIP_DISABLE        BIT(6)
 #define IVPU_TEST_MODE_DISABLE_TIMEOUTS   BIT(8)
 #define IVPU_TEST_MODE_TURBO             BIT(9)
 extern int ivpu_test_mode;
index 82a57a3..39ba6d3 100644 (file)
@@ -35,7 +35,8 @@ static int ivpu_preemption_buffers_create(struct ivpu_device *vdev,
        u64 primary_size = ALIGN(vdev->fw->primary_preempt_buf_size, PAGE_SIZE);
        u64 secondary_size = ALIGN(vdev->fw->secondary_preempt_buf_size, PAGE_SIZE);
 
-       if (vdev->fw->sched_mode != VPU_SCHEDULING_MODE_HW)
+       if (vdev->fw->sched_mode != VPU_SCHEDULING_MODE_HW ||
+           ivpu_test_mode & IVPU_TEST_MODE_MIP_DISABLE)
                return 0;
 
        cmdq->primary_preempt_buf = ivpu_bo_create(vdev, &file_priv->ctx, &vdev->hw->ranges.user,
@@ -347,8 +348,7 @@ static int ivpu_cmdq_push_job(struct ivpu_cmdq *cmdq, struct ivpu_job *job)
        if (unlikely(ivpu_test_mode & IVPU_TEST_MODE_NULL_SUBMISSION))
                entry->flags = VPU_JOB_FLAGS_NULL_SUBMISSION_MASK;
 
-       if (vdev->fw->sched_mode == VPU_SCHEDULING_MODE_HW &&
-           (unlikely(!(ivpu_test_mode & IVPU_TEST_MODE_PREEMPTION_DISABLE)))) {
+       if (vdev->fw->sched_mode == VPU_SCHEDULING_MODE_HW) {
                if (cmdq->primary_preempt_buf) {
                        entry->primary_preempt_buf_addr = cmdq->primary_preempt_buf->vpu_addr;
                        entry->primary_preempt_buf_size = ivpu_bo_size(cmdq->primary_preempt_buf);