drm/i915: Don't try to partition WOPCM without GuC firmware
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Wed, 7 Aug 2019 17:00:31 +0000 (17:00 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 7 Aug 2019 19:53:16 +0000 (20:53 +0100)
For meaningful WOPCM partitioning we need GuC (and optionally HuC)
firmware size(s) and we shouldn't just rely on GuC support flag,
as we might fail to fetch GuC firmware and it's size will be 0
and all calculations will be just wrong/useless.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190807170034.8440-5-michal.wajdeczko@intel.com
drivers/gpu/drm/i915/intel_wopcm.c

index 4c22143..5e5c3fd 100644 (file)
@@ -170,7 +170,7 @@ void intel_wopcm_init(struct intel_wopcm *wopcm)
        u32 guc_wopcm_rsvd;
        int err;
 
-       if (!USES_GUC(i915))
+       if (!guc_fw_size)
                return;
 
        GEM_BUG_ON(!wopcm->size);