pwm: jz4740: Use regmap_{set,clear}_bits
authorPaul Cercueil <paul@crapouillou.net>
Mon, 24 Oct 2022 20:52:13 +0000 (21:52 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 29 Nov 2022 12:06:47 +0000 (13:06 +0100)
Simplify a bit the code by using regmap_set_bits() and
regmap_clear_bits() instead of regmap_update_bits() when possible.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-jz4740.c

index 1a1a651..3b7067f 100644 (file)
@@ -88,8 +88,7 @@ static int jz4740_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
        struct jz4740_pwm_chip *jz = to_jz4740(chip);
 
        /* Enable PWM output */
-       regmap_update_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm),
-                          TCU_TCSR_PWM_EN, TCU_TCSR_PWM_EN);
+       regmap_set_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm), TCU_TCSR_PWM_EN);
 
        /* Start counter */
        regmap_write(jz->map, TCU_REG_TESR, BIT(pwm->hwpwm));
@@ -113,8 +112,7 @@ static void jz4740_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
         * In TCU2 mode (channel 1/2 on JZ4750+), this must be done before the
         * counter is stopped, while in TCU1 mode the order does not matter.
         */
-       regmap_update_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm),
-                          TCU_TCSR_PWM_EN, 0);
+       regmap_clear_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm), TCU_TCSR_PWM_EN);
 
        /* Stop counter */
        regmap_write(jz->map, TCU_REG_TECR, BIT(pwm->hwpwm));
@@ -184,8 +182,8 @@ static int jz4740_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
        regmap_write(jz4740->map, TCU_REG_TDFRc(pwm->hwpwm), period);
 
        /* Set abrupt shutdown */
-       regmap_update_bits(jz4740->map, TCU_REG_TCSRc(pwm->hwpwm),
-                          TCU_TCSR_PWM_SD, TCU_TCSR_PWM_SD);
+       regmap_set_bits(jz4740->map, TCU_REG_TCSRc(pwm->hwpwm),
+                       TCU_TCSR_PWM_SD);
 
        /*
         * Set polarity.