leds: flash: leds-qcom-flash: Add a separate register map for PMI8998
authorFenglin Wu <fenglin.wu@oss.qualcomm.com>
Tue, 29 Jul 2025 04:51:23 +0000 (12:51 +0800)
committerLee Jones <lee@kernel.org>
Mon, 18 Aug 2025 08:49:12 +0000 (09:49 +0100)
The 3-channel flash module in PMI8998 has several registers different
than the others, such as: torch_clamp. Add different register fields
for it.

Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250729-fix-torch-clamp-issue-v2-2-9b83816437a3@oss.qualcomm.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/flash/leds-qcom-flash.c

index db7c2c7..b03a683 100644 (file)
@@ -118,6 +118,22 @@ enum {
        REG_MAX_COUNT,
 };
 
+static const struct reg_field mvflash_3ch_pmi8998_regs[REG_MAX_COUNT] = {
+       [REG_STATUS1]           = REG_FIELD(0x08, 0, 5),
+       [REG_STATUS2]           = REG_FIELD(0x09, 0, 7),
+       [REG_STATUS3]           = REG_FIELD(0x0a, 0, 7),
+       [REG_CHAN_TIMER]        = REG_FIELD_ID(0x40, 0, 7, 3, 1),
+       [REG_ITARGET]           = REG_FIELD_ID(0x43, 0, 6, 3, 1),
+       [REG_MODULE_EN]         = REG_FIELD(0x46, 7, 7),
+       [REG_IRESOLUTION]       = REG_FIELD(0x47, 0, 5),
+       [REG_CHAN_STROBE]       = REG_FIELD_ID(0x49, 0, 2, 3, 1),
+       [REG_CHAN_EN]           = REG_FIELD(0x4c, 0, 2),
+       [REG_THERM_THRSH1]      = REG_FIELD(0x56, 0, 2),
+       [REG_THERM_THRSH2]      = REG_FIELD(0x57, 0, 2),
+       [REG_THERM_THRSH3]      = REG_FIELD(0x58, 0, 2),
+       [REG_TORCH_CLAMP]       = REG_FIELD(0xea, 0, 6),
+};
+
 static const struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
        [REG_STATUS1]           = REG_FIELD(0x08, 0, 7),
        [REG_STATUS2]           = REG_FIELD(0x09, 0, 7),
@@ -862,13 +878,20 @@ static int qcom_flash_led_probe(struct platform_device *pdev)
                return rc;
        }
 
-       if (val == FLASH_SUBTYPE_3CH_PM8150_VAL || val == FLASH_SUBTYPE_3CH_PMI8998_VAL) {
+       if (val == FLASH_SUBTYPE_3CH_PM8150_VAL) {
                flash_data->hw_type = QCOM_MVFLASH_3CH;
                flash_data->max_channels = 3;
                regs = devm_kmemdup(dev, mvflash_3ch_regs, sizeof(mvflash_3ch_regs),
                                    GFP_KERNEL);
                if (!regs)
                        return -ENOMEM;
+       } else if (val == FLASH_SUBTYPE_3CH_PMI8998_VAL) {
+               flash_data->hw_type = QCOM_MVFLASH_3CH;
+               flash_data->max_channels = 3;
+               regs = devm_kmemdup(dev, mvflash_3ch_pmi8998_regs,
+                                   sizeof(mvflash_3ch_pmi8998_regs), GFP_KERNEL);
+               if (!regs)
+                       return -ENOMEM;
        } else if (val == FLASH_SUBTYPE_4CH_VAL) {
                flash_data->hw_type = QCOM_MVFLASH_4CH;
                flash_data->max_channels = 4;