spi: rockchip-sfc: Use dev_err_probe() in the probe path
authorDragan Simic <dsimic@manjaro.org>
Sun, 29 Sep 2024 09:21:15 +0000 (11:21 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 8 Oct 2024 17:41:05 +0000 (18:41 +0100)
Use function dev_err_probe() in the probe path instead of dev_err() where
appropriate, to make the code a bit more uniform and compact.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Dragan Simic <dsimic@manjaro.org>
Link: https://patch.msgid.link/398229ef316e64dc0c27944ea793dcddef1ead4e.1727601608.git.dsimic@manjaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rockchip-sfc.c

index 505d508..7e0fb49 100644 (file)
@@ -580,16 +580,14 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
                return PTR_ERR(sfc->regbase);
 
        sfc->clk = devm_clk_get(&pdev->dev, "clk_sfc");
-       if (IS_ERR(sfc->clk)) {
-               dev_err(&pdev->dev, "Failed to get sfc interface clk\n");
-               return PTR_ERR(sfc->clk);
-       }
+       if (IS_ERR(sfc->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(sfc->clk),
+                                    "Failed to get sfc interface clk\n");
 
        sfc->hclk = devm_clk_get(&pdev->dev, "hclk_sfc");
-       if (IS_ERR(sfc->hclk)) {
-               dev_err(&pdev->dev, "Failed to get sfc ahb clk\n");
-               return PTR_ERR(sfc->hclk);
-       }
+       if (IS_ERR(sfc->hclk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(sfc->hclk),
+                                    "Failed to get sfc ahb clk\n");
 
        sfc->use_dma = !of_property_read_bool(sfc->dev->of_node, "rockchip,sfc-no-dma");